Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进状态表中记录的演出列表和内存中演出列表数据结构的一致性 #581

Open
MakinoharaShoko opened this issue Nov 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@MakinoharaShoko
Copy link
Member

状态表中记录的演出是“如何启动演出”的信息,而内存中是演出控制块。所以这两者不是同步的,而是分别维护的。这样的分别维护造成了同步异常。应当改进,改为内存中的演出信息记录更多信息,每次需要同步的时候,map 到状态表中需要的信息,再一次性写入整个列表,而不是分别添加。

@MakinoharaShoko MakinoharaShoko added enhancement New feature or request high priority labels Nov 3, 2024
@MakinoharaShoko
Copy link
Member Author

此外,还出现了读档后存档,状态表中的演出异常增加的问题。因为读档后,存档中的 PerformList 会写到状态表中。而 restorePerform 又会往存档中写一份。该问题已经通过避免写入重复 id 的演出的方式修复,但今后仍需在恢复演出的逻辑上做出更正。

@MakinoharaShoko MakinoharaShoko added resolve immediately This issue needs to be addressed immediately and a new release published to fix it. and removed high priority labels Nov 3, 2024
@MakinoharaShoko
Copy link
Member Author

目前来看,只影响具有 id 的效果音播放。

@MakinoharaShoko
Copy link
Member Author

修复:读取存档时意外在状态表中存储了多份演出记录的问题;带有 id 的效果音播放在停止后演出未完全清除的问题;对状态表和演出控制器中的演出列表在插入时去重
一致性问题仍然需要今后处理

@MakinoharaShoko MakinoharaShoko removed the resolve immediately This issue needs to be addressed immediately and a new release published to fix it. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant