Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo: Add hyperlinks to imports that have multiple items #423

Open
ericglau opened this issue Dec 17, 2024 · 0 comments
Open

Cairo: Add hyperlinks to imports that have multiple items #423

ericglau opened this issue Dec 17, 2024 · 0 comments

Comments

@ericglau
Copy link
Member

Hyperlinks for contract imports are injected for use lines, which previously imported single items only.

In #417, this changed multiple items from the same package to be imported in the same line (or multiple lines), which our hyperlink injection does not detect.

Examples:

use openzeppelin::governance::governor::{DefaultConfig, GovernorComponent};
use openzeppelin::governance::governor::extensions::{
	GovernorCountingSimpleComponent, GovernorSettingsComponent,
	GovernorTimelockExecutionComponent, GovernorVotesQuorumFractionComponent
};

We should determine a scheme for detecting these imports and where it should link to.

Perhaps for the above examples, we can just link to the prefixed package directories on GitHub: https://github.com/OpenZeppelin/cairo-contracts/tree/main/packages/governance/src/governor
https://github.com/OpenZeppelin/cairo-contracts/tree/main/packages/governance/src/governor/extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant