-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Royalties for NFTs #70
Comments
Let's remove the part about access control. I don't think a "royalty setter" role is the way this will be used in general.
This should be enough to get started. |
Would like to see this to be implemented too, will this be implemented in the future? |
Hello, I was just looking into this project today. I have a diff for this on gmertk@29d903e If it is ok for you, I can send a pull request after OpenZeppelin/openzeppelin-contracts#3012 is merged. Cheers! |
That's awesome @gmertk! Feel free to open a Draft PR any time and we can begin reviewing. It's not going to be merged until royalties are released in OpenZeppelin Contracts later this month. |
Add options for users to be able to integrate royalties on their
ERC721
andERC1155
contracts. This is a suggested set of changes:Include it on the options after selecting ERC721 or ERC1155.
Populating those fields would inherit from the tokenRoyalty contract and call the setDefaultRoyalty from the constructor.
Include this parts on the code:
import "@openzeppelin/contracts/token/tokenERC/extensions/tokenERCRoyalty.sol";
contract MyToken is ERC721, AccessControl {
We'll use Access control to handle the roles of who can set royalties.Take into consideration for the ERC1155, if the user specifies royalties and select ERC1155Supply do not import it btwice into the code, since the royalties contract inherits from this module.
The text was updated successfully, but these errors were encountered: