[Feature]: Make E2E Target Names Easier to Use (i.e. Make _e2e-tests.sh_ Script Easier to Use) #443
Labels
effort: low
Easy or tiny task that takes less than a day.
priority: 0
Nice-to-have. Willing to ship without this.
type: ref
A code update that doesn't meaningfully change functionality.
type: test
Changes to the testing suite.
What is the feature you would like to see?
E.g. currently there's no way to run only
safe-erc20-example
e2e tests without modifying the e2e-tests.sh script.This is because we run our e2e tests from the workspace, which looks at file names to filter out specific tests to run.
Let's say you wanted to run them - you'd probably write something like:
./scripts/e2e-tests.sh safe-erc20*
This will error out with the following log:
A couple of problems are immediately noticeable:
SafeErc20
.This may not be necessarily a problem for us who are intimately acquainted with our code base, but it will be a problem for any new contributor, both external, and potentially internal ones.
I propose we make it even easier and clearer how to run e2e tests from the command line using one of the below approaches:
Pros:
safe-erc20*
- note the asterisk) becomes easier.Cons:
Pros:
Cons:
std
feature in all examples.I'm in favor of option 1) just because when a wrong target name is typed, the error log contains all valid targets.
Contribution Guidelines
The text was updated successfully, but these errors were encountered: