Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Improvements #142

Open
JaredCrean2 opened this issue May 23, 2018 · 0 comments
Open

Misc Improvements #142

JaredCrean2 opened this issue May 23, 2018 · 0 comments

Comments

@JaredCrean2
Copy link
Contributor

JaredCrean2 commented May 23, 2018

A handful of notes from Prof. Hicken's introduction to the code

  • in Euler, split calcBCFlux into one function for computing the flux, another for computing the residual update (precompute=false)
  • change test system tags to match case between the variable names and the names that are supplied on the command line
  • Possibly add error if no tests are run (indicating the provided tag is incorrect)
  • Add comments next to every include() statement
  • Advertise the test/clean_all.sh script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant