Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assignment of family names #3

Open
pedrosenna opened this issue Dec 5, 2022 · 2 comments
Open

Wrong assignment of family names #3

pedrosenna opened this issue Dec 5, 2022 · 2 comments

Comments

@pedrosenna
Copy link

Hello guys, just found this package and i'm really digging it, congratulations.

Just wanted to point out a minor error in the assignment of family level column. It seems to be a problem when the script splits author names containing a dot (.) When the dot is present, the characters after the dot goes into the family column.

For example:

Knodus cinarucoensis (Román-Valencia, Taphorn & Ruiz-C. 2008)
Hemibrycon guejarensis Román-Valencia, Ruiz-C. & Taphorn 2018

chara.db <- search_cas(query = "characidae", type = "species_family") %>%
  filter(status == "Validation") %>% distinct(family) %>% print(n=Inf)
# A tibble: 19 × 1
   family                             
   <chr>                              
 1 Characidae_Stethaprioninae         
 2 Characidae_Characinae              
 3 Characidae_Stevardiinae            
 4 Characidae_Aphyocharacinae         
 5 Characidae_Cheirodontinae          
 6 Characidae_Spintherobolinae        
 7 Characidae_Tetragonopterinae       
 8 2008)                              
 9 Characidae_Characids incertae sedis
10 1967                               
11 2009)                              
12 & Taphorn 2018                     
13 Characidae_Exodontinae             
14 & Taphorn 2010                     
15 & Taphorn 2012                     
16 2007                               
17 & Barriga Salazar 2006             
18 & Barriga Salazar 2005             
19 2008                       

Hope you guys can fix it in the next updates. Also, would be great to be able to pull out the type locality and occurrence records/drainages.

Cheers,

Pedro Bittencourt

@brunomioto
Copy link

Hi Pedro!

We (@Otoliths and me) are trying to re-develop this package to fix all the error and get more variables (as you asked)!

I didn't have time this past months, but will try to work on it this month!

@brunomioto
Copy link

Here's the preview of the new function

chara.db <- search_cas(query = "characidae", type = "species_family") %>%
  filter(status_type == "Validation") %>% distinct(family) %>% print(n=Inf)
# A tibble: 1 x 1
  family    
  <chr>     
1 Characidae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants