Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt more conventions and strategies from lightkurve #143

Open
gully opened this issue Jun 29, 2023 · 0 comments
Open

Adopt more conventions and strategies from lightkurve #143

gully opened this issue Jun 29, 2023 · 0 comments

Comments

@gully
Copy link
Member

gully commented Jun 29, 2023

Lightkurve is great, well-liked, and battled-tested. While it applies to time-series photometry, many of its signal processing steps could be directly applied to muler, with some modest alterations. A good example is plotting, as brought up by @ericasaw in #142.

I encourage prospective contributors to muler consider experimenting with lightkurve first to see what kind of user experience we strive for, and then skimming through the source code to see a benchmark for conventions, style, and modularity.

If folks are keen on this, I suggest we use this thread to collect examples of lightkurve code that we could port to muler. We already have .flatten(). We could add .bin(), .plot() for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant