Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGRINSSpectrumList Note #151

Open
ericasaw opened this issue Jan 12, 2024 · 1 comment
Open

IGRINSSpectrumList Note #151

ericasaw opened this issue Jan 12, 2024 · 1 comment

Comments

@ericasaw
Copy link
Collaborator

Just a reminder for us later, IGRINSSpectrumList in the current main version of muler v.0.4.0 doesnt allow you to pass in an array of fluxes and wavelengths to construct an IGRINSSpectrumList object. This should be fixed in the newest add_flux_calibration branch--but just a note for us later

@gully
Copy link
Member

gully commented Jan 12, 2024

On tradeoff with this directly-populate approach is that the IGRINSSpectrumList will lack metadata associated with the spectrum (such as time stamps, RA, and Dec). So certain opertations, like barycentric_correct won't work. That's fine, we'll simply want to anticipate such scenarios by raising informative error messages when users attempt to call IGRINSSpectrumList when such metadata is not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants