Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job py #864

Open
nicolasaunai opened this issue Jul 25, 2024 · 5 comments
Open

job py #864

nicolasaunai opened this issue Jul 25, 2024 · 5 comments
Milestone

Comments

@nicolasaunai
Copy link
Member

if not used and outdated maybe it should be deleted
functional test are examples in some way, but mostly for python and not phareexe

@PhilipDeegan
Copy link
Member

PhilipDeegan commented Jul 27, 2024

which file specifically?

find . -name job.py
./build/tests/amr/messengers/job.py
./build/tests/amr/multiphysics_integrator/job.py
./build/tests/initializer/job.py
./pyphare/pyphare/pharein/examples/job.py
./tests/initializer/job.py

@PhilipDeegan
Copy link
Member

functional test are examples in some way, but mostly for python and not phareexe

functional tests with only a single simulation can be configured for phare-exe with minimal changes

mostly the following, which is what I've been doing locally

if __name__ == "__main__":
    main()
elif ph.PHARE_EXE:
    config()

and possible conditionally running startMPI() in python only if not running in phare-exe

@PhilipDeegan
Copy link
Member

I guess it's ./pyphare/pyphare/pharein/examples/job.py

@nicolasaunai
Copy link
Member Author

I think too

@PhilipDeegan
Copy link
Member

I've deleted it as part of #888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants