Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for default settings that play nicely with gnome-helper #17

Closed
not-a-doctor-stromberg opened this issue Dec 7, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@not-a-doctor-stromberg
Copy link
Contributor

Hi Maximilian,

My preferred driver settings are:

rockchip_ebc.bw_mode=1 rockchip_ebc.default_waveform=1 rockchip_ebc.refresh_threshold=30 rockchip_ebc.auto_refresh=1

I tried setting those in extlinux.conf, but the bw_mode at least is overwritten by the gnome helper here.

It seems like in other places we read the file first with _get_content (in _add_auto_refresh_button for example) -- I will try doing something similar for changing bw mode (and will try to clean up the spacing as well).

Let me know if you disagree with this approach. I am planning on issuing a pull request for this, but if someone beats me to it, no problamo :)

@m-weigand
Copy link
Collaborator

Hi,
thanks for bringing up this issue - indeed parameters should not be overwritten by the gnome extension.

It would be nice if you could use this location for drafting your merge request, as the recipes repo only holds a copy of the gnome extensions. Also note that managing of ebc parameters will be outsourced to the dbus daemon (see linked branch below).

https://github.com/m-weigand/mw_pinenote_misc/tree/dbus_integration/gnome_extension

Thanks again!

@not-a-doctor-stromberg
Copy link
Contributor Author

Closing in favor of: m-weigand/mw_pinenote_misc#5

@not-a-doctor-stromberg not-a-doctor-stromberg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants