Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error status for the engine non availability #123

Open
vletoux opened this issue Apr 21, 2020 · 0 comments
Open

Better error status for the engine non availability #123

vletoux opened this issue Apr 21, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vletoux
Copy link

vletoux commented Apr 21, 2020

On the engine page (/engines/list), there is a status (which can be refreshed and the engine queried)

In the case below, there is only "Error" written.
You don't know if the engine is down, if there is a problem with the output of the engine, a proxy error, an authentication error, ...
image

I suggest to create the following status:

  • if you received a proxy error, return Proxy Denied (such as connection terminated)
  • if you receive a network error (such as port close), return Connection Denied
  • if you have a time out, return "TimeOut" or "Unavailable"
  • if there is an authentication error with the plugin (401 or 403 error), return "Not authenticated"
  • if you receive a data, but which cannot be interpreted, return "Data error"
@MaKyOtOx MaKyOtOx self-assigned this Jun 2, 2020
@MaKyOtOx MaKyOtOx added the enhancement New feature or request label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants