Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate epoch.sh file #4

Open
adityakiran1423 opened this issue Nov 25, 2024 · 5 comments
Open

Seperate epoch.sh file #4

adityakiran1423 opened this issue Nov 25, 2024 · 5 comments
Assignees

Comments

@adityakiran1423
Copy link
Contributor

Was just going through the codebase and the Dockerfile, any reason for not having epoch.sh as a separate file? Would help contributors avoid another step in running epoch-cli.

@santanusinha
Copy link
Contributor

You can send a PR and update the doc with a step to wget the file from github directly

@adityakiran1423
Copy link
Contributor Author

Sure, that works!! I actually wanted to address this in an issue since I didn't know if this was intentional or not. I'll create a PR. Should it be a wget command in the readme or a separate epoch shell file?

@santanusinha
Copy link
Contributor

add the shell file with this:

#! /bin/sh
docker run \
    --rm --interactive --tty --network host \
    --name epoch-cli -v ${HOME}/.epoch:/root/.epoch:ro  \
    ghcr.io/phonepe/epoch-cli:latest "$@"

in the readme, add a line to pull this file from repo using wget .. sothat person doesn't need to clone the whole repo to get one file

@adityakiran1423
Copy link
Contributor Author

Sure thing

@adityakiran1423
Copy link
Contributor Author

Created a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants