Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.46 tries to create a Wayland window by default #514

Open
cloudhead opened this issue Nov 6, 2022 · 7 comments
Open

Version 0.46 tries to create a Wayland window by default #514

cloudhead opened this issue Nov 6, 2022 · 7 comments

Comments

@cloudhead
Copy link

Since Wayland support was added, it seems like glfw will try to create a wayland window by default. This is because the "wayland" feature is active by default. Disabling it requires using default-features: false on glfw.

Was this the intent? It seems like it might be easier to have it off by default, and activate by just using features = ["wayland"].

@cloudhead cloudhead changed the title Version 0.46 tries to create a Wayland window Version 0.46 tries to create a Wayland window by default Nov 6, 2022
@Frostie314159
Copy link
Contributor

Broke it, fixed it, PRed it. #518.

@Frostie314159
Copy link
Contributor

Frostie314159 commented Dec 15, 2022

Until this #518 is merged, just replace glfw = "0.47.0" with glfw = { git = "https://github.com/Frostie314159/glfw-rs-wayland-patch.git"} this temporarily points glfw to my fork with the fix.

@Frostie314159
Copy link
Contributor

Frostie314159 commented Dec 22, 2022

The #518 just got merged, until it is published point it to the main branch.

@orowith2os
Copy link

orowith2os commented Jul 3, 2023

Why do these bindings default to X11? Upstream GLFW will default to Wayland in the next release (well, iirc), and the only major issues that I know of are not having CSDs on GNOME and Weston, which is also fixed in the latest commits.

@Frostie314159
Copy link
Contributor

When I wrote the patch, I wasn't aware of the change. But feel free to revert the change with a PR.

@cloudhead
Copy link
Author

If we want to default to wayland, then we should have an x11 feature that can be turned on. Either way, doesn't really matter as long as it's easy to switch between the two without disabling all features.

@Frostie314159
Copy link
Contributor

Since writing the patch, I've taken a break from writing graphics related stuff and doing more networking. I'm probably not available to write the PR, although it should be a fairly trivial change.

vosen pushed a commit that referenced this issue Nov 5, 2024
fix compilation with older nvcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants