-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.46 tries to create a Wayland window by default #514
Comments
Broke it, fixed it, PRed it. #518. |
Until this #518 is merged, just replace |
The #518 just got merged, until it is published point it to the main branch. |
Why do these bindings default to X11? Upstream GLFW will default to Wayland in the next release (well, iirc), and the only major issues that I know of are not having CSDs on GNOME and Weston, which is also fixed in the latest commits. |
When I wrote the patch, I wasn't aware of the change. But feel free to revert the change with a PR. |
If we want to default to wayland, then we should have an |
Since writing the patch, I've taken a break from writing graphics related stuff and doing more networking. I'm probably not available to write the PR, although it should be a fairly trivial change. |
Since Wayland support was added, it seems like glfw will try to create a wayland window by default. This is because the "wayland" feature is active by default. Disabling it requires using
default-features: false
on glfw.Was this the intent? It seems like it might be easier to have it off by default, and activate by just using
features = ["wayland"]
.The text was updated successfully, but these errors were encountered: