Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to extract the icons from the wiki? #29

Open
uncovery opened this issue May 14, 2020 · 7 comments
Open

Do we want to extract the icons from the wiki? #29

uncovery opened this issue May 14, 2020 · 7 comments

Comments

@uncovery
Copy link

uncovery commented May 14, 2020

I have written a code that extracts the icons from the wiki as well.
It downloads the individual block icons and creates a CSS for the item sprites as well. With the help of imagick or similar we could create individual item images.

Since all the regex and so on already exists here, it would be easy to implement if we wanted.

This is relevant because there is no 1:1 link for all items and block in the JSON data to the image files in minecraft-assets.

Let me know.

@rom1504
Copy link
Member

rom1504 commented May 14, 2020 via email

@uncovery
Copy link
Author

uncovery commented May 14, 2020

There are specifc items that do not exist in the minecraft assets and won't ever, specifically full icons of blocks. The mc-assets rather has the top/bottom/etc images, but no 3D block icons such as this one:

https://gamepedia.cursecdn.com/minecraft_gamepedia/thumb/b/be/Acacia_Log_Axis_Y_JE5_BE3.png/30px-Acacia_Log_Axis_Y_JE5_BE3.png

mc-assets in this case has only the top and side view:
https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log.png
https://github.com/PrismarineJS/minecraft-assets/blob/master/data/1.15.2/blocks/acacia_log_top.png

Further, many blocks do not even have an image file that corresponds to the itemname if you want to link one specific item (such as "microsoft:tall_grass ") to the entry in the mc-data block Json. acacia_log is a lucky one, we would at least have the 2D side view, but others with more "versions" do not have any file that corresponds to the itemname, see sweet_berry_bush, tall_grass and many more.

@rom1504
Copy link
Member

rom1504 commented May 14, 2020 via email

@uncovery
Copy link
Author

Frankly I have no idea. But as of now, the Wiki is the only place where I can get them from.

@rom1504
Copy link
Member

rom1504 commented May 14, 2020 via email

@uncovery
Copy link
Author

I would think so, they are the ones that you see in your inventory. But I do not know if they are "assembled" for display from the textures or if the full icon is stored somewhere.

@Karang
Copy link
Contributor

Karang commented May 15, 2020

The icons for the blocks are created at game initialization using the in-game renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants