Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong mcVersion when using with multiple versions #30

Open
Gjum opened this issue Aug 18, 2021 · 2 comments
Open

Wrong mcVersion when using with multiple versions #30

Gjum opened this issue Aug 18, 2021 · 2 comments

Comments

@Gjum
Copy link
Member

Gjum commented Aug 18, 2021

Calling loader(mcversion) twice with different versions returns the same ChatMessage instance, using the last mcVersion for both instances.

Instead, it should remember the mcVersion passed to the loader.

relevant source code
@nickelpro
Copy link
Member

Surely defaultLang should just be a property of ChatMessage? Is anything relying on this being a global? Agreed this is an un-intuitive bug

@rom1504
Copy link
Member

rom1504 commented Aug 19, 2021

the way the loader works currently is completely broken
check other packages to see good examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickelpro @rom1504 @Gjum