Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't setup pre-commit integration; please cut new release #591

Open
ngie-eign opened this issue Aug 16, 2021 · 2 comments
Open

Can't setup pre-commit integration; please cut new release #591

ngie-eign opened this issue Aug 16, 2021 · 2 comments

Comments

@ngie-eign
Copy link

ngie-eign commented Aug 16, 2021

pre-commit requires a revision in order to function and given that .pre-commit-hooks.yaml was added after the last release, end-users can't use the pre-commit integration provided in commit a9c6a37 without specifying an explicit git hash.

While a git hash would suffice for rev, I would really appreciate an official release be cut so folks can rely on that version for integration, instead of a random version off master, as the quality of that version is unknown.

Thanks!

@bityob
Copy link

bityob commented Jan 30, 2022

@ngie-eign You right. I'm just using rev master instead of specifying the version

@bityob
Copy link

bityob commented Jan 30, 2022

@edschofield Any news about releasing a new release?

As @ngie-eign wrote, current version doesn't work fine with pre-commit because of the missing hook file

user@host:~/Code/project $ pre-commit
[INFO] Initializing environment for https://github.com/PythonCharmers/python-future.
An error has occurred: InvalidManifestError: 
=====> /home/user/.cache/pre-commit/repo6ec7nce2/.pre-commit-hooks.yaml is not a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants