Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Interfaces #81

Merged
merged 14 commits into from
Apr 7, 2024
Merged

Refactor Interfaces #81

merged 14 commits into from
Apr 7, 2024

Conversation

GiggleLiu
Copy link
Collaborator

@GiggleLiu GiggleLiu commented Apr 6, 2024

  • Separate the problem definition and the tensor network construction. e.g.
    • IndependentSet(graph; weights, optimizer) -> GenericTensorNetwork(IndependentSet(graph, weights), optimizer)
  • Remove ReducedProblem.
  • API name change
    • terms to energy_terms
    • NoWeight to UnitWeight
  • Refactor Spinglass problem
    • Merge Spinglass and HyperSpinGlass
    • Changed the convension from $-J s_i s_j$ to $J s_i s_j$

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 96.46018% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (43e64c2) to head (a63acba).

Files Patch % Lines
src/networks/networks.jl 91.42% 3 Missing ⚠️
src/networks/PaintShop.jl 84.61% 2 Missing ⚠️
src/networks/SpinGlass.jl 94.73% 2 Missing ⚠️
src/interfaces.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   89.15%   90.93%   +1.78%     
==========================================
  Files          33       31       -2     
  Lines        1871     1820      -51     
==========================================
- Hits         1668     1655      -13     
+ Misses        203      165      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiggleLiu GiggleLiu merged commit 0d23e37 into master Apr 7, 2024
5 checks passed
@GiggleLiu GiggleLiu mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant