Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the public-ip crate to get the proper IP for the Cluster Server. #8

Open
3 tasks
Makosai opened this issue Dec 27, 2024 · 0 comments
Open
3 tasks
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Makosai
Copy link
Member

Makosai commented Dec 27, 2024

https://github.com/avitex/rust-public-ip needs to be used to improve this code:

let ip = "127.0.0.1".as_bytes(); // TODO: Use public_ip to get an actual IP.

Importing the crate would be simple. But I'm wondering if there's a more efficient solution. The solution doesn't really matter since it's only done once. If someone wants to implement this feel free to choose either route. It should be a quick ~5 line update with the public_ip crate going in the cluster crate and the version coming from the Workspace.

  • Add public_ip to cluster crate.
  • Store the version in the Workspace.
  • Replace ip with public_ip value.
@Makosai Makosai added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant