-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BP-OSD #22
add BP-OSD #22
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 53.45% 58.96% +5.51%
==========================================
Files 13 14 +1
Lines 507 580 +73
==========================================
+ Hits 271 342 +71
- Misses 236 238 +2 ☔ View full report in Codecov by Sentry. |
@Krastanov please help review this PR, thanks! |
This looks good, thanks! It seems there are two new JET warnings in your code. Could you please see whether you can address them:
|
Besides the warnings, this is good to merge. We should also post an issue about improvements to it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking as "request changes"
@Krastanov I have fixed the JET warnings. Please help me review the changes, thanks! |
This PR includes an implementation of BP-OSD (belief propagation with ordered statistics post-processing).
Reference: Algorithm 1 in paper.
In my tests, the implementation to work well an provide better decoding accuracy than BP alone for some classical codes.
I think it is suitable to be considered a first PR.
Future TODOs: The performance is not optimized. Also, to use it for quantum codes, some adaptions need to be done along with the QuantumClifford side.