Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Cyrillic-based languages #911

Open
sakhnik opened this issue May 6, 2023 · 2 comments
Open

Improve support for Cyrillic-based languages #911

sakhnik opened this issue May 6, 2023 · 2 comments

Comments

@sakhnik
Copy link
Contributor

sakhnik commented May 6, 2023

Currently, QuickEvent is fine-tuned for Latin-based scripts. Characters are stripped of diacritics and narrowed down to 7-bit ASCII. This makes filtering, searching and other string operations typo-tolerant. But the collation algorithm fails dramatically with any other script, for instance, Cyrillic. When I try to filter names, a match is found in every row.
I ended up with a temporary fix to just compare strings ordinarily, and this works just fine: 6177c5e.
But a more robust solution acceptable for anyone could be a choice of either the Latin-based collation or the generic one. This could be a configuration option or automatic selection based on the current locale, maybe.

@fvacek
Copy link
Collaborator

fvacek commented May 8, 2023

Can you provide some table, how ti narrow Cyrillic characters to 7-bit, or do you think that convert to lower-case is enough for you?

@sakhnik
Copy link
Contributor Author

sakhnik commented May 9, 2023

I believe that converting to lowercase would be perfect for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants