Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang errors caused by cppcoreguidelines-avoid-capture-default-when-capturing-this #2231

Closed
TedThemistokleous opened this issue Sep 22, 2023 · 1 comment · Fixed by #3723
Closed

Fix clang errors caused by cppcoreguidelines-avoid-capture-default-when-capturing-this #2231

TedThemistokleous opened this issue Sep 22, 2023 · 1 comment · Fixed by #3723
Assignees
@TedThemistokleous
Labels
Continous Integration Pull request updates parts of continous integration pipeline dependencies Pull requests that update a dependency file Under Investigation

Comments

@TedThemistokleous
Copy link
Collaborator

TedThemistokleous commented Sep 22, 2023 •
edited
Loading

Seen in PR #2201 , cpp core guidlines checks started being flagged once we went to ROCm 5.7

Currently we've suppressed these errors to get ROCm 5.7 in CI but these should be fixed to avoid the warning.
@TedThemistokleous TedThemistokleous self-assigned this Sep 22, 2023
@TedThemistokleous TedThemistokleous added dependancies Continous Integration Pull request updates parts of continous integration pipeline labels Sep 22, 2023
@kahmed10 kahmed10 added dependencies Pull requests that update a dependency file and removed dependancies labels Dec 30, 2023
@taylding-amd taylding-amd mentioned this issue Dec 18, 2024
Merged
@taylding-amd
Copy link
Contributor

The clang-tidy check passed after enabling the check again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedThemistokleous TedThemistokleous

Labels
Continous Integration Pull request updates parts of continous integration pipeline dependencies Pull requests that update a dependency file Under Investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable cpp core guidlines checks. ROCm/AMDMIGraphX
4 participants
@kahmed10 @TedThemistokleous @ppanchad-amd @taylding-amd