Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: offload compress v1 unsupported #99

Open
trixirt opened this issue Oct 25, 2024 · 2 comments
Open

[Issue]: offload compress v1 unsupported #99

trixirt opened this issue Oct 25, 2024 · 2 comments

Comments

@trixirt
Copy link

trixirt commented Oct 25, 2024

Problem Description

Ref: https://github.com/ROCm/clr/blob/amd-staging/hipamd/src/hip_code_object.cpp#L77
totalSize element was introduced in v2 of this feature.
llvm-18 will produce v1.
When a v1 is encountered, the next field 'uncompressedBinarySize' is used which is wrong and will result in a segfault.
As a runtime, all the versions should be supported or if not flagged as a runtime error.

Operating System

Fedora Rawhide

CPU

ALL

GPU

ALL

ROCm Version

ROCm 6.2.3

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@schung-amd
Copy link

Hi @trixirt, thanks for bringing this to our attention. It should be straightforward for us to differentiate between v1 and v2 headers using the versionNumber field. I'll discuss this with the internal team to figure out how we want to handle this scenario.

@trixirt
Copy link
Author

trixirt commented Oct 28, 2024

The hard part I believe will be how to figure out the size of packet.
Here is my workaround.
https://src.fedoraproject.org/rpms/rocclr/blob/rawhide/f/0001-handle-v1-of-compressed-fatbins.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants