Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: WSL is supported #339

Open
1 task done
githust66 opened this issue Dec 19, 2024 · 0 comments
Open
1 task done

[Feature]: WSL is supported #339

githust66 opened this issue Dec 19, 2024 · 0 comments

Comments

@githust66
Copy link

githust66 commented Dec 19, 2024

🚀 The feature, motivation and pitch

The current version uses a lot of amdsmi and makes it unusable in WSL, can rocminfo be used instead of amdsmi ? for example :
I used https://github.com/vllm-project/vllm to build vllm from source code, and referred to the get_amdgpu_memory_capacity method in https://github.com/sgl-project/sglang/blob/main/python/sglang/srt/utils.py file to modify the amdsmi-related code in https://github.com/vllm-project/vllm/blob/main/vllm/platforms/__init__.py file, using rocminfo instead of amdsmi. This allows vllm to be used on wsl.
image

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant