Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP address in use message could use some tweaking #199

Open
aldrichdev opened this issue Jan 10, 2024 · 2 comments
Open

IP address in use message could use some tweaking #199

aldrichdev opened this issue Jan 10, 2024 · 2 comments

Comments

@aldrichdev
Copy link

This always says only 1 character can be used at once, regardless of the MAX_PLAYERS_PER_IP setting.

Maybe change it to something more generic like "You may only use so many accounts at once" unless the current message is important for authenticity.

image

@Hubcapp
Copy link
Member

Hubcapp commented Jan 10, 2024

Unfortunately, that message is hard-coded in the client and can't be changed.

It is definitely confusing to users, and so a custom response code (possibly of 26) is a definite addition for upcoming openrsc server type extensions. type 26 should allow the server to send the client a custom string to display. Type 26 when received by an unmodified 234 client will just show a generic error message, but not crash. Maybe we can also send a different client version to inform the server we understand more than an unmodified 234 client, but maybe that's not desired. We'll see.

@Hubcapp
Copy link
Member

Hubcapp commented Jan 10, 2024

We could also just change the message for that response code in openrsc server config mode. Maybe there is a custom packet that is ignored by base 234 client, but rsc+ client with openrsc extensions can interpret it similarly to the "server configs" packet in the Custom Client protocol, and it could inform the client how many characters at once are allowed, which is,.... probably the best approach. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants