Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area specific music #71

Open
Hubcapp opened this issue Jan 19, 2021 · 2 comments
Open

Area specific music #71

Hubcapp opened this issue Jan 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Hubcapp
Copy link
Member

Hubcapp commented Jan 19, 2021

Similar to later games, it would be nice to have a toggle to enable or disable music. It would be nice to use libADLMIDI to produce these sounds, to give the midis a lo-fi sound.

@thelegendofbrian
Copy link
Contributor

Would we just use RS tracks from 04/05? There are a number of sources we could take the coordinate data from and adapt to the RSC map. http://rsmusicmap.corymartin.net/ is one site.

It’d be doubly nice to have a way for servers with new or non-canon areas update or add to the track list. Having the server manage/host the midis would also take any copyright liability off of the client.

@Hubcapp
Copy link
Member Author

Hubcapp commented Feb 4, 2021

Yeah, we could just use Ian Taylor's RS tracks from 2004. But it should be possible for the user to easily substitute in arbitrary midis.

The original RS2 soundfont sounds wrong to me in RSC, but it could be an option. @sean-niemann implemented it in his single player client here if you'd like to try a demo & feel how it feels. (Their project is licensed under GPLv3 by the way, which is compatible with our license). Their implementation currently lacks fading the music between zones, which I think is needed for zones where the music style changes abruptly (e.g. between Rimmington & Port Sarim)

Stated in OP, I think libADLMIDI would be a great fit for RSC.

Re: "It'd be nice to have a way for servers with new or non-canon areas update or add to the track list"; It is not currently a goal of RSC+ to support non-canon areas. The code for loading the cache from the server would have to be put back in in order to support new landscapes. And I guess that's where you would want to load a "music1.jag" file. It's not a goal of RSC+ currently because custom private servers that exist currently use a lot of inauthentic opcodes in addition to adding new areas, so even if you're loading the cache from them, the RSC+ client would have to be modified heavily, to the point of being a private server client, which is not a direction I'd like to see it go.

Personally I'd like for there always be an option to load cache locally, so I know that I'm using only authentic content. It gives the user more control over the program if it doesn't rely on the server for its cache.

I was thinking for this issue, we would have like a "sound pack" that you'd have to acquire from outside the client. And maybe just drag and drop in a "music.zip" file that RSC+ would read. Some other 3rd party loader for RSC+ could insert that music.zip file automatically in order to get around copyright liability.

Hubcapp added a commit that referenced this issue Jul 27, 2022
#71 #72 Audio Settings. Music pack support. Boundary Map Lookup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants