No text baseline alignment for combobox labels

[AlexFalappa]

The problem mainly shows in the options dialog, for exemple here:

And here:

[AlexFalappa]

The problem is in the original Darcula Look And Feel.
I have fixed it and submitted PR bulenkov/Darcula#18 to the original project.
With a custom built look and feel jar the options dialog is now:

And:

[AlexFalappa]

The fix is also available in my fork of the Darcula Look And Feel

[markiewb]

@Revivius: How about including the jar of @AlexFalappa's fork instead of the original?

[Revivius]

@markiewb I think it is a very good idea to include @AlexFalappa's fork because original repo seems to be inactive for quite some time. Lets target this for v1.5

[AlexFalappa]

@Revivius thanks for considering my contributions.

Here is the complete list of my fork improvements over the original Darcula LAF:

• Restore JComboBox baseline calculation: shown above
• Better icons for JOptionPane: this is based on my previous PR to nb-darcula New JOptionPane icons #59, but adds HiDPI version of the icons and eliminates some transparency fringing on normal icons
• Fix possible ArrayOutOfBoundsException in DarculaSpinnerUI: this "backported" the spinner improvements made in nb-darcula to the Darcula LAF
• Darcula JToggleButton LAF support: this adds support for JToggleButton that otherwise retains the appearance of the Metal LAF with dark colors

[Revivius]

@AlexFalappa how should we proceed ? Your improvements will render some classes in ui package obsolete. Is it possible for you to create a pull request containing the JAR built from your fork and removing unrequired classes in ui package ?

[AlexFalappa]

@Revivius sure, I will try to cook up something this evening.

[AlexFalappa]

Done as PR #86

[AlexFalappa]

I see that the PR has diverged from master, would you like me to rebase?

[Revivius]

@AlexFalappa; yes please. I want to check and merge this PR as soon as possible. I am sorry for the delay.

[AlexFalappa]

Made a better PR #89.
Apologies for my delay too

[AlexFalappa]

Will close my previous PR

[AlexFalappa]

@Revivius you should be able to merge cleanly now

[Revivius]

@AlexFalappa; merged, thank you for combobox baseline fix.

Next time we should consider updating the version of the jar in lib folder. Files in lib folder (which we declare as a repo in pom) seems to be copied to local maven repo (under user home) during build. Since there already was a com.bulenkov.darcula-1.0.0.jar in my local repo I had hard time understanding why your fixes was not working. Deleting the jar from my local maven repo (again under user home) caused the updated jar (in lib folder from your PR) to be copied to there and until that point I could see modifications to jar within NetBeans and also build started to use new jar so I could see your fixes.

[AlexFalappa]

@Revivius good to know that.
I was also thinking to change the maven coordinates of my fork to better distinguish it from the original one (changing the group id for example).