Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio message edit functionality sends a new message instead of editing the existing one #696

Open
smritidoneria opened this issue Dec 19, 2024 · 5 comments · May be fixed by #697
Open
Labels
bug Something isn't working

Comments

@smritidoneria
Copy link
Contributor

Description:

When a user sends a audio message in the chat and clicks on the "Edit" option, they can record another video. However, instead of editing the existing message, the application sends a new message with the newly recorded audio.

Steps to reproduce:

1.Send a audio message in the chat.
2. Click on the "Edit" option for the audio message.
3.Record another audio and confirm the edit.
4. Observe that instead of editing the existing message, a new message is sent with the updated audio.

Expected behavior:

The existing audio message should be updated with the newly recorded audio when edited.

Actual behavior:

A new message is sent with the updated audio instead of editing the existing one.

Screen.Recording.2024-12-19.at.9.40.32.AM.mov
@smritidoneria smritidoneria added the bug Something isn't working label Dec 19, 2024
@dhairyashiil dhairyashiil linked a pull request Dec 19, 2024 that will close this issue
1 task
@devanshkansagra
Copy link
Contributor

devanshkansagra commented Dec 19, 2024

Hey @smritidoneria, I think currently there is no point of raising this issue because this behaviour is there in rocketchat as well, may be they have not fixed yet. I also faced similar situations in my pr of recursive quoting #641, in that also when you quote a quoted uploaded attachment(audio, video or file), it won't show the preview in the message. This is also an issue in the main rocketchat as well.

Embedded Chat
image

Rocket chat
image

@devanshkansagra
Copy link
Contributor

@Spiral-Memory what are your thoughts on this?

@Spiral-Memory
Copy link
Collaborator

The issue is good as well as useful..
Usually other chat apps don't allow it including Rocket.Chat

We might need to see why they don't usually implement this.

@smritidoneria
Copy link
Contributor Author

Maybe we do not let the user to edit the video and audio messages.

1 similar comment
@smritidoneria
Copy link
Contributor Author

Maybe we do not let the user to edit the video and audio messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants