Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: video modal responsiveness #726

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Dec 24, 2024

Brief Title

Acceptance Criteria fulfillment

  • Set the height of the modal to 100% to ensure proper scaling on smaller screens.
  • Adjust the video container to height: 100% and use object-fit: cover for better alignment and scaling of the video.

Fixes #725

Video/Screenshots

video-modal-fix.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-726 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010 abirc8010 changed the title video modal fix fix: video modal responsiveness Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness issue for video message modal
1 participant