This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Exceptions from constructing the protocol object should have enumerated errors instead of raw integers #10

Open

jbrover opened this issue Mar 11, 2021 · 0 comments

Labels

jbrover commented Mar 11, 2021

try/catch statements when constructing the protocol object currently check values -1, -2 etc.

These should be enumerated in librover.

https://github.com/RoverRobotics/roverrobotics_ros2/blob/fixes/roverrobotics_driver/src/roverrobotics_ros2_driver.cpp

jackarivera added the enhancement label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.