Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to CMake code needed #40

Open
derpda opened this issue Dec 20, 2020 · 0 comments
Open

Improvements to CMake code needed #40

derpda opened this issue Dec 20, 2020 · 0 comments

Comments

@derpda
Copy link

derpda commented Dec 20, 2020

The cmake code for this library causes the exact same (very expensive) compilation to happen many times over when building examples.
Building anything with Eigen is already expensive, so I think it would be best to avoid this.

If there is no good reason for this then I would be happy to make some changes to the CMake code and submit a PR.
Currently there isn't actually a HODLR library, and changing that could drastically improve compilation time.

I am also trying to use HODLR in my own project, and several improvements to the CMake code could greatly improve the user experience.
Again, I would be happy to make some improvements in a PR if that is OK.

@derpda derpda mentioned this issue Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant