Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python installation failure #9

Open
gregreen opened this issue Jun 6, 2016 · 5 comments
Open

Python installation failure #9

gregreen opened this issue Jun 6, 2016 · 5 comments

Comments

@gregreen
Copy link

gregreen commented Jun 6, 2016

The python installation fails with the following error message:

hodlr/_hodlr.cpp: In function ‘int _hodlr_init(_hodlr*, PyObject*, PyObject*)’:
hodlr/_hodlr.cpp:93:42: error: no matching function for call to ‘HODLR_Tree<Gaussian_Matrix>::assemble_Matrix(Eigen::VectorXd&, double&)’
     self->solver->assemble_Matrix(dv, tol);
                                          ^
In file included from hodlr/_hodlr.cpp:6:0:
../header/HODLR_Tree.hpp:73:7: note: candidate: void HODLR_Tree<MatrixType>::assemble_Matrix(HODLR_Node<MatrixType>*&) [with MatrixType = Gaussian_Matrix]
  void assemble_Matrix(HODLR_Node<MatrixType>*& node) {
       ^
../header/HODLR_Tree.hpp:73:7: note:   candidate expects 1 argument, 2 provided
../header/HODLR_Tree.hpp:188:7: note: candidate: void HODLR_Tree<MatrixType>::assemble_Matrix(Eigen::VectorXd&, double, char) [with MatrixType = Gaussian_Matrix; Eigen::VectorXd = Eigen::Matrix<double, -1, 1>]
  void assemble_Matrix(VectorXd& diagonal, double lowRankTolerance, char s) {
       ^
../header/HODLR_Tree.hpp:188:7: note:   candidate expects 3 arguments, 2 provided

It looks like the problem is that char s is not being provided by _hodlr_init to HODLR_Tree<MatrixType>::assemble_Matrix.

@gregreen
Copy link
Author

gregreen commented Jun 6, 2016

I'm guessing this bug was introduced by c69cf44.

@dfm
Copy link
Collaborator

dfm commented Jun 7, 2016

Hi Greg,

I'd recommend taking a look at the dev version of george (especially the HODLRSolver and the custom kernel tutorial) if you want to use this solver with custom matrices in Python. I'd be inclined to drop Python support from this repo anyways since it would also take some work to get this working with Python 3, for example. If that doesn't work for you, let us know what you're trying to do and maybe we can come up with something.

Thanks!

@gregreen
Copy link
Author

gregreen commented Jun 7, 2016

Hi Dan,

Thanks for the tip about George. I came across it soon after finding this bug, and the python support looks much better. I'll give it a try.

Thanks!

@EskreisWinkler
Copy link

I am interested in studying the properties of this HODLR solver as a kernel approximation tool apart from its ability to solve systems of equations related to GPs. Is it possible to use this HODLR solver to somehow extract the actual matrix entries?

@EskreisWinkler
Copy link

To be specific - I am having trouble seeing how to compute the HODLR approximation of a PSD matrix (which may or may not be based on a specific kernel function). So can I input a matrix with entries that are directly user-specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants