-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
naming of range tables #286
Comments
Nice question! I usually use: Don't know what the correct way to do it indeed. |
IMO, there can be multiple company codes (plural) in the range (singular). Therefore, i prefer using this: data RANGE_OF_COMPANY_CODES type range of T001-BUKRS. |
I do If I see |
There is no perfect answer to this but in any case the sections Use descriptive names and Use plural should provide an outline to assist your in finding a good name for your context: Consider this fictitious example with some context:
For the goal of understanding this code I believe it is sufficient to consider a range(s) table a set definition (in the mathematical sense) and thus simply use the plural. |
I think I agree to a point, one thing that comes to mind though is that the variable does not actually contain a list of company codes like |
Yes, I was aware that it is not actually a list of company codes - hence the pointer to the mathematical definition of a set that may describe it by the properties of its elements (i.e. a set-builder notation or set comprehension). To understand the goal of the algorithm, however, this "implementation detail" should not be required. Using the |
Agree with @fabianlupa and @N2oB6n-SAP. In my non-prefixed code, I mostly use One confusing thing about naming ranges is that it's unclear what exactly "the range" is: Is it one row in the table, because it could be a |
As I try to stick with singular and plural should a range table be named in plural or singular? I ask this because a range table is a special type.
`data company_code_range type range of t001-bukrs.
data company_code_ranges type range of t001-bukrs.`
The text was updated successfully, but these errors were encountered: