Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motor Driver rewrite #88

Open
SuperChamp234 opened this issue Oct 21, 2023 · 2 comments
Open

Motor Driver rewrite #88

SuperChamp234 opened this issue Oct 21, 2023 · 2 comments
Assignees
@SuperChamp234

Comments

@SuperChamp234
Copy link
Member

The MCPWM driver has been redesigned, and the legacy driver has been depreciated.

The new MCPWM driver is object-oriented, where most of the MCPWM submodule has a driver object associated with it. The driver object is created by factory function. IO control function always needs an object handle, in the first place.

The component currently uses the legacy drivers, which needs to be updated.

More info: https://docs.espressif.com/projects/esp-idf/en/v5.1.1/esp32/migration-guides/release-5.x/5.0/peripherals.html#adc-oneshot-continuous-mode-drivers
@SuperChamp234 SuperChamp234 converted this from a draft issue Oct 21, 2023
@VedantParanjape
Copy link
Member

Object oriented driver in a C code base ?

@SuperChamp234
Copy link
Member Author

Object oriented driver in a C code base ?

Yes, we must create interfaces for the MCPWM timer, comparators, generators and operator ourselves which were previously abstracted by idf.

@SuperChamp234 SuperChamp234 moved this from Todo to In Progress in Porting Component to ESP IDF v5.1 Oct 27, 2023
@SuperChamp234 SuperChamp234 self-assigned this Oct 27, 2023
@SuperChamp234 SuperChamp234 mentioned this issue Jan 10, 2024
Merged
@SuperChamp234 SuperChamp234 moved this from In Progress to Done in Porting Component to ESP IDF v5.1 Jan 28, 2024
@SuperChamp234 SuperChamp234 moved this from Done to In Review in Porting Component to ESP IDF v5.1 Jan 28, 2024
@SuperChamp234 SuperChamp234 moved this from In Review to Done in Porting Component to ESP IDF v5.1 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuperChamp234 SuperChamp234

Labels
None yet
Projects
Porting Component to ESP IDF v5.1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VedantParanjape @SuperChamp234