Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split GitHub Actions workflows #1076

Closed
1 task done
defagos opened this issue Dec 3, 2024 · 2 comments · Fixed by #1090
Closed
1 task done

Split GitHub Actions workflows #1076

defagos opened this issue Dec 3, 2024 · 2 comments · Fixed by #1090
Assignees
@waliid
Labels
tooling Issues related to the tools we use

Comments

@defagos
Copy link
Member

defagos commented Dec 3, 2024 •
edited
Loading

As a Pillarbox developer I want cleaner jobs and associated steps, with smaller definition files and possibly associated with different triggers.

Acceptance criteria

  • The single PR workflow has been split over several smaller workflows (quality, UT, archive).
  • These workflows are triggered on PR creation.

Tasks

  • Separate workflow files.
@defagos defagos added this to Pillarbox Dec 3, 2024
@defagos defagos converted this from a draft issue Dec 3, 2024
@defagos defagos added the tooling Issues related to the tools we use label Dec 3, 2024
@waliid
Copy link
Member

waliid commented Dec 5, 2024 •
edited
Loading

Splitting our Pull request workflow into multiple workflows (one per job) seems like a bad idea to me because we lose a consolidated view of what is happening. Moreover, if we want to stop workflows related to a PR, we would have to stop them individually.

@waliid waliid moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Dec 5, 2024
@waliid waliid self-assigned this Dec 5, 2024
@waliid waliid linked a pull request Dec 5, 2024 that will close this issue
Rename CI workflow #1090
Merged
4 tasks
@waliid
Copy link
Member

waliid commented Dec 5, 2024

Instead of splitting the Pull Request workflow, we've renamed it to CI because this workflow is triggered for both PRs and merge queues.

@defagos defagos moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Dec 5, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waliid waliid

Labels
tooling Issues related to the tools we use
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename CI workflow SRGSSR/pillarbox-apple
2 participants
@defagos @waliid