-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic subtitle selection #503
Comments
I had a look at what is returned by |
We need to clearly identify what Automatic means. After discussions with @amtins and @StaehliJ it appears that our SRG Media Player was likely taking too many decisions and that the definition of this automatic mode should be simpler. It is likely that:
We should therefore:
We should also check whether automatic mode agrees with the result obtained by calling |
See comment elsewhere for an important remark about |
Automatic selection requires |
Some remarks:
|
We finally better (but probably not completely) understand how Automatic (Recommended) works. Note that for a rendition to be selectable automatically, most notably in this mode, it needs to be flagged with Here is how Automatic (Recommended) seems to work to the best of our current knowledge:
Note that this automatic selection logic is affected by accessibility settings, though the idea remains the same. It also seems to be applied when starting playback, not when settings are updated afterwards during playback. The criteria are likely those listed in the official documentation. |
As a user I want automatic subtitle selection to be available. Automatic selection must take care of selecting the most appropriate subtitle selection based on the current audio language.
Acceptance criteria
Documentation
Tasks
Generate new test streams if needed (e.g. stream withDEFAULT
for some language or withAUTOSELECT
not available for all languages).The text was updated successfully, but these errors were encountered: