Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasionally missing Accessibility Label #268

Open
h0shy opened this issue May 31, 2022 · 2 comments
Open

Occasionally missing Accessibility Label #268

h0shy opened this issue May 31, 2022 · 2 comments

Comments

@h0shy
Copy link

h0shy commented May 31, 2022

Issue type

Incorrect behavior

Description of the problem

In Voice Over, the a11y label of the entire Video, which reads "Video, zweimal tippen um Bedienelemente anzuzeigen." doesn't always get read out. In random cases, it just reads "Video".

Environment information

The simulator is a valid device as well. If all versions or devices seem to be affected, simply enter 'Any'

  • Library version: 8.0.0
  • iOS 15.5
  • Device: iPhone 13 Pro Max

Reproducibility

Not always reproducible.

Steps to reproduce

Focus the Video in Voice Over.

@defagos
Copy link
Member

defagos commented Jul 15, 2022

Hi.

Thanks for your report and sorry for the late reply. I'll have a look, as this issue can quite easily be reproduced with VoiceOver enabled:

  1. Focus on the video. The accessibility hint is provided (double tap action).
  2. Double tap to toggle the controls. Now the accessibility hint is missing.

@defagos
Copy link
Member

defagos commented Jul 15, 2022

When describing the player view for VoiceOver we are using two pieces of text:

  1. A short one, the accessibility label, that describes the element.
  2. A longer one which describes what the associated action does, the accessibility hint.

I suspect that an accessibility hint is only spoken the first time the control it is associated with is focused. If you namely use VoiceOver with a switch button (e.g. in the system Settings app), you can hear that the hint (usually "Double tap to toggle setting") is only spoken the first time, not after you toggle the switch without leaving the control. This is likely implemented this way to avoid unnecessary verbosity and matches what we implemented for our player view (whose controls are toggled like a switch would be).

To have the full label always spoken we would need to include the action in the accessibility label itself, which is not what Apple recommends, as labels must be short. So the situation we have, which avoids being verbose about a hint while the focus is kept on a control, seems correct to me.

Of course if you can reproduce a use case where the hint is missing while moving the control to the player view, then we might still have another bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants