Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release compatible with analysis 1.7.0 #46

Closed
proux01 opened this issue Nov 25, 2024 · 14 comments
Closed

Release compatible with analysis 1.7.0 #46

proux01 opened this issue Nov 25, 2024 · 14 comments

Comments

@proux01
Copy link

proux01 commented Nov 25, 2024

@4ever2 @sertel apaprently the latest 0.2.1 release of ssprove is not compatible with the latest 1.7.0 release of analaysis, any plan for a compatible release?

@4ever2
Copy link
Collaborator

4ever2 commented Nov 25, 2024

I will look into it later this week and make a release compatible with analysis.
It looks like the analysis package split broke a few imports.

@sertel
Copy link
Contributor

sertel commented Nov 25, 2024

@4ever2, thanks for taking a look.

@proux01
Copy link
Author

proux01 commented Nov 25, 2024

It looks like the analysis package split broke a few imports.

This should only have moved files, not renamed anything so From mathcomp Require foo should be a backward compatible solution (and is the recommended way to do any mathcomp import in any case).

@4ever2
Copy link
Collaborator

4ever2 commented Nov 25, 2024

SSProve depends on distr.v which was moved to mathcomp-experimental-reals but SSProve doesn't depend on this new package.

@proux01
Copy link
Author

proux01 commented Nov 25, 2024

Apparently adding the dependency is enoug to make it work: coq-community/coq-nix-toolbox#289
Thanks!
I let you either close this or update your README/package files/whatever with the new dependencies before.

@proux01
Copy link
Author

proux01 commented Nov 25, 2024

Hum, apparently I misread the CI result, this is not yet fixed: https://github.com/coq-community/coq-nix-toolbox/actions/runs/12007908356/job/33469475445?pr=289
Sorry

@4ever2
Copy link
Collaborator

4ever2 commented Nov 25, 2024

The remaining issues were already fixed. Main branch compiles with mathcomp-analysis 1.7.0 after added the missing dependency.

@sertel
Copy link
Contributor

sertel commented Nov 26, 2024

@proux01 , I suppose you would need a new release version (for the according update in nixpkgs)?

@proux01
Copy link
Author

proux01 commented Nov 26, 2024

Yes please (I can then take care of the nixpkgs update)

@sertel
Copy link
Contributor

sertel commented Nov 26, 2024

@4ever2 , would it be possible to merge my pending PR and then do the new release, please?
(I just merged in your latest changes.)

@sertel
Copy link
Contributor

sertel commented Nov 26, 2024

Thanks a lot for taking care of the nixpkgs update, @proux01.

@4ever2
Copy link
Collaborator

4ever2 commented Nov 26, 2024

@sertel Yes, will merge it and make a new release once I'm done porting SSProve to Coq 8.20

@4ever2
Copy link
Collaborator

4ever2 commented Nov 27, 2024

SSProve 0.2.2 is released now.
NixOS/nixpkgs#359596

We will need to add mathcomp-experimental-reals as a dependency once mathcomp-analysis 1.7.0 is on nixpkgs

@4ever2 4ever2 closed this as completed Nov 27, 2024
@proux01
Copy link
Author

proux01 commented Nov 28, 2024

Thanks, this works in nixpkgs : coq-community/coq-nix-toolbox#289 (I'm just waiting for a release of infotheo (expected in the coming weeks))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants