search feature - if you want it

[jgarza9788]

https://github.com/jgarza9788/Burn-My-Windows/tree/searchfeature

• re-organized the top widgets ... to make it look nice
• added the search field
• added a filter function (it's simple, but it will do for now) (maybe something like a fuzzy search later)
• made a description field for each effect - so things like "flame" will work for fire and incinerate

[Schneegans]

I think this is a good idea. Especially if you want to add more effects in the future 😄

Although I am not sure about the descriptions - these are very long and pretty hard to translate. This will make it much harder to translate the project and will only bring a small benefit.

And maybe the "All" and "None" buttons should be renamed "Enable All" and "Disable All" to make clear that they do not belong to the search bar.

What do you think?

[jgarza9788]

Yup, I was also thinking about … a filter for enabled and disabled effects. I like working with you, so you can expect this soon… just keep in mind I have a 9-5 and I gotta get some time in for sun and fresh air.

…

On Mon, Oct 28, 2024 at 4:15 PM Simon Schneegans ***@***.***> wrote: I think this is a good idea. Especially if you want to add more effects in the future 😄 Although I am not sure about the descriptions - these are very long and pretty hard to translate. This will make it much harder to translate the project and will only bring a small benefit. And maybe the "All" and "None" buttons should be renamed "Enable All" and "Disable All" to make clear that they do not belong to the search bar. What do you think? — Reply to this email directly, view it on GitHub <#462 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5URPWVLK2YYAJT7UJJT7DZ52ENLAVCNFSM6AAAAABQV5VBHGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBXHE2DCNQ> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[jgarza9788]

i don't mind if you use it or not.
but here it is with the button text changed.

it only makes sense if there are a lot more effects,
we'll see if that happens... i only have a few more in mind to try and submit.

i also tried out filter buttons (i.e. only show enabled, only show disabled, and all)

...

if was a fun little experiment in UI.
but i'll focus more on effects now unless you want something specific with the UI

[Schneegans]

I think the variant with a search bar and the two buttons is great. Do you want to propose this as a pull request?

[jgarza9788]

Sure, I can make a clean branch for you (maybe in a few days, work is getting a bit busy)