Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after vscode update to 1.36.0 #162

Closed
gmtechworks opened this issue Jul 7, 2019 · 16 comments
Closed

Issue after vscode update to 1.36.0 #162

gmtechworks opened this issue Jul 7, 2019 · 16 comments
Labels
bug Something isn't working

Comments

@gmtechworks
Copy link

Error while connecting to SSH FS "connection name":
Error while signing data with privateKey: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR

@badcrc
Copy link

badcrc commented Jul 8, 2019

I'm getting an openssl error too after updating to 1.36.0:

Error while signing data with privateKey: error:06000080:public key routines:OPENSSL_internal:UNSUPPORTED_ALGORITHM

I've tried with a RSA and a DSA keys and both fails.

@sikmike
Copy link

sikmike commented Jul 8, 2019

I can confirm. I am getting the same error connecting to an AWS linux server:

Error while connecting to SSH FS mydev:
Error while signing data with privateKey: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR

@dolbyac3
Copy link

Upgraded to vscode 1.36 and get the following error:

Error while connecting to SSH FS web1:
Error while signing data with privateKey: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR

Reverted back to vscode 1.35.1 and everything works fine.

@jacobmata
Copy link

Same for me after upgrading VSCode
Error while connecting to SSH FS do2: Error while signing data with privateKey: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR

@rotexhawk
Copy link

Same issue on mac.

@SchoofsKelvin
Copy link
Owner

I'm not entirely sure what's going on. It seems like vscode upgraded Electron to 4.x, which uses a new SSL library that dropped support for some key types.

The weird thing is that RSA should still be supported, but @badcrc had an issue with that too?

Version changes:

  • vscode 1.36 upgraded node 10.2.0 to 10.11.0
  • node 10.9.0 updated OpenSSL from 1.1.0h to 1.1.0i
  • upgraded to Electron 4
  • Electron switched to BoringSSL (apparently overriding node's version)

Similar issues:

@SchoofsKelvin SchoofsKelvin added the bug Something isn't working label Aug 5, 2019
@badcrc
Copy link

badcrc commented Aug 6, 2019

I've just tried with a rsa key and seems to work, maybe I didn't try it right the first time.

@SchoofsKelvin
Copy link
Owner

I'll keep this issue open for a while and keep looking around, but right now it seems like it's not something I can fix, without dynamically converting keys if that's even possible.

@dolbyac3
Copy link

dolbyac3 commented Aug 16, 2019

I think it has to do with the key bit size length.

I was using some older rsa keys so I re-generated them with a bit size of 4096 (ssh-keygen -t rsa -b 4096) and they worked with this plugin running on vs code 1.37.1.

Then I generated some new keys with the default bit size (2048) and they did not work. Just to test that.

So if you are having trouble try generating a stronger rsa key.

@rotexhawk
Copy link

I am able to login to my remote servers after the recent VScode update. 1.37.1

@over-engineer
Copy link

@dolbyac3 Yes! Thank you! I was going crazy while trying to fix an issue on an Electron app for the past 3 hours. You really saved my bacon.

@Trimakas
Copy link

Shoot, still having this issue. tried PEM format and the 4096 length format, both with no luck.. anyone else still having this issue?

@jorgehumberto
Copy link

having the same issue here. I am on:

  • Fedora 31 (64)
  • vscode 1.40.2
  • shfs 1.16.3

@SchoofsKelvin
Copy link
Owner

This should be fixed after updating ssh2 (b22dd71) and VSCode updating their node version.

@dylanh724
Copy link

dylanh724 commented Oct 16, 2020

Andd it's back: liximomo/vscode-sftp#830

@SchoofsKelvin
Copy link
Owner

The extension is already using [email protected] which in turn uses [email protected], both the latest versions.
Need to wait on ssh2 to complete its rewrite, or accept this PR: mscdex/ssh2-streams#164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests