Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding NamedArrayPartition type #293

Merged
merged 12 commits into from
Jan 4, 2024

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented Nov 28, 2023

I added a NamedArrayPartition type in https://github.com/jlchan/StartUpDG.jl; in case it's useful, here are the changes as a PR.

The array type is just an array partition with named fields, e.g.,

julia> x = NamedArrayPartition(a = randn(10), b = randn(2,2))
julia> x.a # should return the stored result from randn(10)

The main difference from ArrayPartition is that I require each individual array to have the same eltype. I forgot why I did this originally, but I'm happy to fix this if needed.

@jlchan jlchan mentioned this pull request Nov 28, 2023
6 tasks
@jlchan
Copy link
Contributor Author

jlchan commented Dec 12, 2023

Sorry, dismissed the review after fixing a conflict

@ChrisRackauckas
Copy link
Member

bump the version down to test it.

@jlchan
Copy link
Contributor Author

jlchan commented Dec 13, 2023

bump the version down to test it.

Thanks for the tip. Done in e6d2680, mind approving CI once more?

@jlchan
Copy link
Contributor Author

jlchan commented Dec 13, 2023

Formatting tests were failing for a bunch of files; is it OK if I just lump a bunch of formatting commits into this PR or would you prefer that in a separate one?

@ChrisRackauckas
Copy link
Member

Don't run the formatter, it needs an update.

@jlchan jlchan requested a review from ChrisRackauckas January 4, 2024 04:02
@jlchan
Copy link
Contributor Author

jlchan commented Jan 4, 2024

Thanks for catching that I forgot to load the packages in my tests @ChrisRackauckas. I think I've fixed the last failing test - would you mind approving the CI again?

@ChrisRackauckas
Copy link
Member

Last thing, just add to the docs.

@ChrisRackauckas ChrisRackauckas merged commit 3e2dcdb into SciML:master Jan 4, 2024
15 of 16 checks passed
@jlchan
Copy link
Contributor Author

jlchan commented Jan 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants