-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding NamedArrayPartition
type
#293
Conversation
Sorry, dismissed the review after fixing a conflict |
bump the version down to test it. |
Thanks for the tip. Done in e6d2680, mind approving CI once more? |
Formatting tests were failing for a bunch of files; is it OK if I just lump a bunch of formatting commits into this PR or would you prefer that in a separate one? |
Don't run the formatter, it needs an update. |
Thanks for catching that I forgot to load the packages in my tests @ChrisRackauckas. I think I've fixed the last failing test - would you mind approving the CI again? |
Last thing, just add to the docs. |
Thanks! |
I added a
NamedArrayPartition
type in https://github.com/jlchan/StartUpDG.jl; in case it's useful, here are the changes as a PR.The array type is just an array partition with named fields, e.g.,
The main difference from
ArrayPartition
is that I require each individual array to have the sameeltype
. I forgot why I did this originally, but I'm happy to fix this if needed.