Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider folding WormholeL1VotePool into WormholeL1ERC20Bridge #51

Open
wildmolasses opened this issue Sep 13, 2023 · 1 comment
Open

Consider folding WormholeL1VotePool into WormholeL1ERC20Bridge #51

wildmolasses opened this issue Sep 13, 2023 · 1 comment
Labels
low priority

Comments

@wildmolasses
Copy link
Contributor

wildmolasses commented Sep 13, 2023 •
edited
Loading

this contract is inherited by WormholeL1ERC20Bridge.sol where the method is used.

@alexkeating and I were discussing folding the WormholeL1VotePool contract (which really only contains this method) into the WormholeL1ERC20Bridge. But because of a couple factors, one of which is a test refactoring, we'll defer this for now

Originally posted by @wildmolasses in #38 (comment)
@wildmolasses wildmolasses mentioned this issue Sep 13, 2023
Merged
3 tasks
@alexkeating
Copy link
Collaborator

Also consider making the L1VotePool internal receive method a public method that is inherited by the L1ERC20Bridge. #37 (comment)

@alexkeating alexkeating mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wildmolasses @alexkeating