Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Does it make sense that the popularity is based on quantity and not just appearances #39

Open
loevgaard opened this issue Dec 5, 2024 · 0 comments
Open

[Bug]: Does it make sense that the popularity is based on quantity and not just appearances #39

loevgaard opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@loevgaard
Copy link
Member

Plugin version

master

Sylius version

1.12

What happened?

The PopularityDataMapper is basing the popularity metric on SUM(quantity), but what if a product was added 200 times to the cart on one order, then that would skew your expected results.

Shouldn't we just count the number of unique times a product appears?

Relevant log output

No response
@loevgaard loevgaard added the bug Something isn't working label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loevgaard