Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For ABCL #51

Open
junkerjoe opened this issue Nov 12, 2020 · 2 comments · May be fixed by #52
Open

Add Support For ABCL #51

junkerjoe opened this issue Nov 12, 2020 · 2 comments · May be fixed by #52

Comments

@junkerjoe
Copy link

It would be nice to have the roadblocks laid out here so that if someone wanted to -- or as I get enough experience to -- add ABCL support, it could be referenced here. Any thoughts/suggestions you could share @tizoc?

@tizoc
Copy link
Member

tizoc commented Nov 12, 2020

Hi @junkerjoe. All the credit of making shen-cl portable across Common Lisp implementations goes to @rkoeninger (without his work, shen-cl would only support SBCL and CLisp), he should be able to give you a better answer (my guess is he just didn't try it, but I may be wrong here).

@junkerjoe have you tried compiling shen-cl with ABCL? if yes, what didn't work? boot.lsp is where you should probably look first, I'm not familiar with ABCL but I guess you need some ABCL-specific code in there. Then after that, there are some variables that need to be initialized in src/primitives.lsp.

I'm not familiar with ABCL, but if it is like most Common Lisp implementations, it shouldn't be hard to make shen-cl work with ABCL too.

@rkoeninger
Copy link
Member

I considered adding ABCL support a while ago but didn't know if there would be any interest and forgot about it. I could look at it when I find some time or does joe want to take a shot at it?

A good way to start adding support would be by searching the codebase for #+ and #- as those signal the inclusion/exclusion of code on a platform basis.

Another good platform to support would be CLASP as it appears to be the new hotness in the CL implementation space.

@rkoeninger rkoeninger linked a pull request Nov 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants