-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint, highlight and complete snippet signatures #211
Comments
👋🏻 there's a second part to this that would be extremely helpful for theme developers; checking what values for params are available. While knowing if a param of type {%- comment -%}
Some kind of snippet that outputs an image of different sizes
@param {Object} image - Image object
@param {'33'|'50'|'66'} media_width - Width of the media
{%- endcomment -%} The syntax here is based on JSDoc's specification for type unions. Not sure if the formatting is the most optimal in a Liquid context, but it's an idea. There are also other things we can check for. For example, auto-completion of |
Yeah I think #114 wants to address just that. Hard to prioritize right now but definitely still something on our radar :) |
Some thoughts on the matter:
Valid syntax examples:
Wrote this on my phone, now my fingers hurt~ |
We're now tracking this by Request for suggestions: LiquidDoc Shopify/liquid#1852 |
Is your feature request related to a problem? Please describe.
A new look at #448
When you type
{% render 'snippet', arg1: some_value %}
, we don't check that that snippet needs thatarg1
variable, nor do we do reliably reportUndefinedObject
in the snippet.Describe the solution you'd like
I'd like something that helps folks on both ends.
Describe alternatives you've considered
{% # global arg1, arg2, arg3 %}
comment at the top of the fileThe text was updated successfully, but these errors were encountered: