Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a block should update old references #547

Open
charlespwd opened this issue Oct 29, 2024 · 0 comments · May be fixed by #655
Open

Renaming a block should update old references #547

charlespwd opened this issue Oct 29, 2024 · 0 comments · May be fixed by #655
Assignees
Labels

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Oct 29, 2024

Is your feature request related to a problem? Please describe.
When a block/*.liquid file is renamed, references to it should be updated to the new name

Describe the solution you'd like
When a block/*.liquid file is renamed, references to it should be renamed:

  • In block presets?

  • In section presets?

  • In sections/*.json files

  • In templates/*.json files

  • {% content_for "block", type: 'oldName' %}

  • if a block becomes private and it was previously included by @theme, a { type: "_newName"} should be appended to the list of block definitions. EDIT not doing this one. Too much work and would cause a lot of toil.

Additional context
https://shopify.dev/docs/storefronts/themes/architecture/blocks/theme-blocks#render-a-theme-block

@charlespwd charlespwd changed the title Update theme block references when theme blocks are renamed Renaming a block should update old references Dec 5, 2024
@charlespwd charlespwd self-assigned this Dec 5, 2024
@charlespwd charlespwd linked a pull request Dec 5, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant