Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: consider agility level and quest completion for shortcuts. #4

Open
cxexx opened this issue Jun 16, 2022 · 2 comments
Open

Comments

@cxexx
Copy link

cxexx commented Jun 16, 2022

For instance, the white wolf mountain shortcut is always recommended even if fishing contest is not yet completed. Or various agility shortcuts that can't be used because it needs a grapple, or an agility level that isn't high enough. etc.
it would be nice if we can disable shortcuts or if it can detect our level / quest and then not use those shortcuts.

@Jlambs
Copy link

Jlambs commented Jun 20, 2022

Agility level requirements are being worked on in another branch already: https://github.com/Skretzo/shortest-path/tree/agility-shortcut-requirements

The file https://github.com/Skretzo/shortest-path/blob/master/src/main/resources/transports.txt has annotations for some additional quest and dialogue requirements, but they don't appear to be used yet.

@Skretzo
Copy link
Owner

Skretzo commented Jun 20, 2022

The following has been added to the plugin:
(and will be available in RuneLite as soon as the review process is completed, typically a week for these kind of changes)
(edit: it is live now):

  • 1. Option to include/exclude agility shortcuts with agility level requirements
  • 2. Option to include/exclude crossbow grapple shortcuts with agility, ranged and strength level requirements

With 1) and/or 2) enabled the plugin will check if you have the required level to use the shortcut.
I am aware that many agility shortcuts are still missing. I will add them eventually, but the work is a bit tedious.

The following has not yet been added to the plugin:

  • 3. Option to include/exclude shortcuts/transports/doors etc. with quest requirements (e.g. Fishing Contest)
  • 4. Option to include/exclude shortcuts/transports/doors etc. with item requirements (e.g. crossbow & grapple, key, coins)

I want to implement 3) and 4), but where do you draw the line? Should I also optionally warn/display when you do not have the requirements/items in your inventory? And then you have teleports... This is a different rabbit hole that I know the OSRS Wiki wants to implement at one point, but it is easier said than done. For now, I think I will go for a simple solution with no missing requirement warning, but rather toggleable options to consider quest and item requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants