"is_used_for_promo_rules" is not handled in getFieldAnalyzers

[mvenghaus]

If you want to use a text attribute only in promo rules, not searchable, not filterable, you get the wrong default search analyzer.

https://github.com/Smile-SA/elasticsuite/blob/2.11.x/src/module-elasticsuite-core/Index/Mapping/Field.php#L377

Here every text attribute gets the keyword analyzer by default. To filter in promos it should get the untouched analyzer to work like it should. The "is_used_for_promo_rules" is not handled there. If you try to use it without, the checkAnalyzer fails and you get an empty propertyName.

I think s.th. like this could solve this

if ($this->getType() === self::FIELD_TYPE_TEXT) {

if ($this->getType() === self::FIELD_TYPE_TEXT && !$this->IsUsedForPromoRules()) {

Then you get the same analyzer like a filterable field.

Preconditions

Magento Version : 2.4.6

ElasticSuite Version : 2.11.5.1

Environment : Developer

Third party modules : -

Steps to reproduce

Create a text attribute with only "is_used_for_promo_rules" enabled.

..
use Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\CollectionFactory as ProductCollectionFactory;
..

$productCollection = $this->productCollectionFactory->create()
    ->addFieldToFilter('text_attribute', ['eq' => 'value']);

[romainruaud]

Hi @mvenghaus

Maybe changing this line would be better, no ?

https://github.com/Smile-SA/elasticsuite/blob/2.11.x/src/module-elasticsuite-core/Index/Mapping/Field.php#L391

if (empty($analyzers) || $this->isFilterable() || $this->isUsedForPromoRules()) {

I'd prefer to add the untouched when needed, rather than "removing the keyword so that the untouched will be added after". It seems more understandable for me.

Your thoughts ?

[mvenghaus]

Hey @romainruaud ,

in my understanding the first analyzer is used as the default analyzer. Would the expected analyzer check fail because the untouched is the second one?

[romainruaud]

The default analyzer is the one returned by getDefaultAnalyzer, it's not the first one.

Did you give a try to my proposal ? It should work the same way as yours, except that the field would still have the keyword as default, and another untouched analyzer being added.

Regards

[github-actions]

This issue was waiting update from the author for too long. Without any update, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away! Thanks for your contribution.

[mvenghaus]

Hey @romainruaud,

adding an addtional untouched analyzer works. I've created a pull request where this is handled.

#3230

Regards
Marcus