From 5167f02aa1df2c145b2d3a202ca9086f46b4d859 Mon Sep 17 00:00:00 2001 From: Scott Winkler Date: Wed, 25 Oct 2023 02:33:48 -0700 Subject: [PATCH] update makefile --- .github/workflows/generate.yml | 4 ++-- .github/workflows/reviewdog-golanglint-ci.yml | 4 ++-- .github/workflows/reviewdog-staticcheck.yml | 6 +++--- .reviewdog.yml | 3 +++ 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index 16e3f84c19..842c03b413 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -11,8 +11,8 @@ permissions: # pull-requests: read jobs: - golangci: - name: lint + generate: + name: generate runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/reviewdog-golanglint-ci.yml b/.github/workflows/reviewdog-golanglint-ci.yml index 954d161924..dfe1e0e655 100644 --- a/.github/workflows/reviewdog-golanglint-ci.yml +++ b/.github/workflows/reviewdog-golanglint-ci.yml @@ -1,4 +1,4 @@ -name: golangci-lint +name: reviewdog-golangci-lint on: push: branches: @@ -11,7 +11,7 @@ permissions: # pull-requests: read jobs: - golangci: + lint: name: lint runs-on: ubuntu-latest steps: diff --git a/.github/workflows/reviewdog-staticcheck.yml b/.github/workflows/reviewdog-staticcheck.yml index 6208b1e4c9..f3319e3d79 100644 --- a/.github/workflows/reviewdog-staticcheck.yml +++ b/.github/workflows/reviewdog-staticcheck.yml @@ -1,8 +1,8 @@ -name: reviewdog +name: reviewdog-staticcheck on: [pull_request] jobs: staticcheck: - name: runner / staticcheck + name: staticcheck runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 @@ -15,4 +15,4 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review filter_mode: nofilter - fail_on_error: true + fail_on_error: false diff --git a/.reviewdog.yml b/.reviewdog.yml index cae280c47f..cecdb5668a 100644 --- a/.reviewdog.yml +++ b/.reviewdog.yml @@ -1,3 +1,6 @@ +# Copyright (c) Snowflake, Inc. +# SPDX-License-Identifier: MIT + runner: golangci: cmd: golangci-lint run --out-format=line-number --timeout 5m