Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: snowflake_account_parameter WEEK_START #3245

Open
1 task
danielefrigo opened this issue Dec 4, 2024 · 1 comment
Open
1 task

[Bug]: snowflake_account_parameter WEEK_START #3245

danielefrigo opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
bug Used to mark issues with provider's incorrect behavior resource:account_parameter Issue connected to the snowflake_account_parameter resource

Comments

@danielefrigo
Copy link

Terraform CLI Version

1.9.8

Terraform Provider Version

0.99

Company Name

No response

Terraform Configuration

While creating a snowflake_account_parameter resource (parameter WEEK_START), Terraform accepts only values 0 or 1, while this parameter accepts any value from 0 to 7.
https://docs.snowflake.com/en/sql-reference/parameters#week-start

Category

category:resource

Object type(s)

resource:account_parameter

Expected Behavior

accept any value from 0 to 7

Actual Behavior

accept only 0 or 1

Steps to Reproduce

resource "snowflake_account_parameter" "week_start" { key = "WEEK_START" value = 7 }

How much impact is this issue causing?

High

Logs

No response

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@danielefrigo danielefrigo added the bug Used to mark issues with provider's incorrect behavior label Dec 4, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @danielefrigo. Thanks for reaching out to us.

Accounts are being currently reworked and we should soon have a separate resource to manage the given account, however, we will still keep snowflake_account_parameter (at least for v1.x), so we will fix this before the next release.

@sfc-gh-asawicki sfc-gh-asawicki added the resource:account_parameter Issue connected to the snowflake_account_parameter resource label Dec 5, 2024
@sfc-gh-jmichalak sfc-gh-jmichalak self-assigned this Dec 13, 2024
sfc-gh-jmichalak added a commit that referenced this issue Dec 20, 2024
<!-- Feel free to delete comments as you fill this in -->
- Add missing parameters based on the docs and output of SHOW PARAMETERS
IN ACCOUNT
- Add missing unit tests and implementations
- Add missing validations
- Relax validations for ints - just validate if they are non-negative
- Update docs
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
#3044 
#3116
#3245

## TODO
- Do not add missing user parameters - this will be done in
SNOW-1844996. Here, they are added only to account and session level
- More acceptance and integration tests should be done on a separate
account. This should be done during account resource follow-up
(SNOW-1866453)
sfc-gh-asawicki pushed a commit that referenced this issue Dec 20, 2024
<!-- Feel free to delete comments as you fill this in -->
- Add missing parameters based on the docs and output of SHOW PARAMETERS
IN ACCOUNT
- Add missing unit tests and implementations
- Add missing validations
- Relax validations for ints - just validate if they are non-negative
- Update docs
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
#3044 
#3116
#3245

## TODO
- Do not add missing user parameters - this will be done in
SNOW-1844996. Here, they are added only to account and session level
- More acceptance and integration tests should be done on a separate
account. This should be done during account resource follow-up
(SNOW-1866453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to mark issues with provider's incorrect behavior resource:account_parameter Issue connected to the snowflake_account_parameter resource
Projects
None yet
Development

No branches or pull requests

3 participants