Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make listener contracts more clear and enforceable, OR remove them #5408

Open
georgii-borovinskikh-sonarsource opened this issue May 7, 2024 · 0 comments

Comments

@georgii-borovinskikh-sonarsource
Copy link
Contributor

We currently have models & interfaces for SLCoreListeners living in the main SLCore assembly, while the implementations live in the SLCore.Listeners assembly.

For example, src/SLCore/Listener/Logger/ILoggerListener.cs vs. src/SLCore.Listeners/Implementation/LoggerListener.cs

The issue is that the ILoggerListener interface is marked as unused, which may confuse people unfamiliar with the project. The initial goal of adding the interfaces was to declare an external contract mainly for self-documentation's sake, but also for possible mock-ing in ITs later.

It needs to be made clear and self-evident what the purpose of those interfaces is, otherwise they need to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant